Skip to content

sander/tsConfigFile#532

Merged
SanderElias merged 5 commits intomasterfrom
sander/tsConfigFile
May 6, 2020
Merged

sander/tsConfigFile#532
SanderElias merged 5 commits intomasterfrom
sander/tsConfigFile

Conversation

@SanderElias
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

instead of using JS, we can now use TS for config files. Scully will compile the TS down js before
it loads it
@SanderElias SanderElias requested a review from jorgeucano May 6, 2020 14:07
@SanderElias SanderElias merged commit 4720514 into master May 6, 2020
@SanderElias SanderElias deleted the sander/tsConfigFile branch May 6, 2020 14:24
atao60 pushed a commit to atao60/scully that referenced this pull request May 6, 2020
* feat(scully): use typescript for config files

instead of using JS, we can now use TS for config files. Scully will compile the TS down js before
it loads it

* fix(scully): tS compile config only when updated

* fix(scully): remove build artifact

* fix(scully): remve antoher artifact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants